Handle all annotation source request failures - #2695
Merged
Conversation
Treat any error while fetching an HTTP annotation source as an unavailable source. This lets annotations continue with other configured sources when network failures such as connection resets occur.
paracycle
approved these changes
Aug 4, 2026
paracycle
left a comment
paracycle
left a comment
Member
There was a problem hiding this comment.
Approach seems reasonable to me
Morriar
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Ran into this issue in this CI run: https://github.com/Shopify/tapioca/actions/runs/30581510365/job/91002633500?pr=2669#step:6:151
Implementation
Treat any error while fetching an HTTP annotation source as an unavailable source. I briefly looked into exception classes that can be raised and there were too many, I think the risk of calling
say_http_errorwith a non network related exception in this function is low so I went with this approach instead of adding more exception classes.Tests